On Thu, Jul 10, 2014 at 12:26:07PM +0800, WANG Chao wrote: > Currently map_vm_area() takes (struct page *** pages) as third argument, > and after mapping, it moves (*pages) to point to (*pages + nr_mappped_pages). > > It looks like this kind of increment is useless to its caller these > days. The callers don't care about the increments and actually they're > trying to avoid this by passing another copy to map_vm_area(). > > The caller can always guarantee all the pages can be mapped into > vm_area as specified in first argument and the caller only cares about > whether map_vm_area() fails or not. > > This patch cleans up the pointer movement in map_vm_area() and updates > its callers accordingly. > > v2: Fix arch/tile/kernel/module.c::module_alloc(). > > Signed-off-by: WANG Chao <chaowang@xxxxxxxxxx> > --- > arch/tile/kernel/module.c | 2 +- > drivers/lguest/core.c | 7 ++----- > drivers/staging/android/binder.c | 4 +--- > include/linux/vmalloc.h | 2 +- > mm/vmalloc.c | 14 +++++--------- > mm/zsmalloc.c | 2 +- > 6 files changed, 11 insertions(+), 20 deletions(-) Staging code: Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>