On Wed, Jul 2, 2014 at 11:03 AM, Laura Abbott <lauraa@xxxxxxxxxxxxxx> wrote: > > For architectures without coherent DMA, memory for DMA may > need to be remapped with coherent attributes. Factor out > the the remapping code from arm and put it in a > common location to reduced code duplication. > > Signed-off-by: Laura Abbott <lauraa@xxxxxxxxxxxxxx> Hm. The switch from ioremap to map_vm_area() here seems to imply that lib/ioremap can/should be reworked to use just wrap the vmalloc functions too? Unrelated to this change. I did a pass of review here. Nothing stands out as wrong but I don't claim to know this area well these days. What's the merge/ack plan here? It might reduce the complexity of merging to add the common functions in your series, then move the ARM code over separately? -Olof -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>