On Wed, 09 Jul 2014 07:45:06 +0800 Wang Sheng-Hui <shhuiw@xxxxxxxxx> wrote: > >> +unsigned long vm_total_pages; > >> > >> static LIST_HEAD(shrinker_list); > >> static DECLARE_RWSEM(shrinker_rwsem); > > > > Nice patch! It's good to document these little things as one discovers > > them. > > > > However vm_total_pages is only ever used in build_all_zonelists() and > > could be made a local within that function. > > We can see that vm_total_pages is not used in build_all_zonelist() only. > http://lxr.oss.org.cn/search?string=vm_total_pages Look more closely ;) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>