On 07/08/2014 11:21 PM, Cyrill Gorcunov wrote: > Otherwise we may not notice that pte was softdirty because pte_mksoft_dirty > helper _returns_ new pte but not modifies argument. > > CC: Pavel Emelyanov <xemul@xxxxxxxxxxxxx> > CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx> Acked-by: Pavel Emelyanov <xemul@xxxxxxxxxxxxx> > --- > mm/memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6.git/mm/memory.c > =================================================================== > --- linux-2.6.git.orig/mm/memory.c > +++ linux-2.6.git/mm/memory.c > @@ -2744,7 +2744,7 @@ void do_set_pte(struct vm_area_struct *v > if (write) > entry = maybe_mkwrite(pte_mkdirty(entry), vma); > else if (pte_file(*pte) && pte_file_soft_dirty(*pte)) > - pte_mksoft_dirty(entry); > + entry = pte_mksoft_dirty(entry); > if (anon) { > inc_mm_counter_fast(vma->vm_mm, MM_ANONPAGES); > page_add_new_anon_rmap(page, vma, address); > . > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>