On Mon, 7 Jul 2014, Vladimir Davydov wrote:
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index d31c4bacc6a2..95a8f772b0d1 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -294,8 +294,12 @@ struct kmem_cache *memcg_create_kmem_cache(struct mem_cgroup *memcg,
> if (IS_ERR(s)) {
> kfree(cache_name);
> s = NULL;
> + goto out_unlock;
> }
>
> + list_add(&s->memcg_params->siblings,
> + &root_cache->memcg_params->children);
> +
> out_unlock:
> mutex_unlock(&slab_mutex);
>
If there is an error then s is set to NULL. And then
the list_add is done dereferencing s?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>