On 07/04/2014 09:57 AM, Joonsoo Kim wrote: > Isolation is really rare case so !is_migrate_isolate() is > likely case. Remove unlikely macro. Good catch. Why not replace it with likely then? Any difference in the assembly? > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 8dac0f0..0d4cf7a 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -735,7 +735,7 @@ static void free_one_page(struct zone *zone, > zone->pages_scanned = 0; > > __free_one_page(page, pfn, zone, order, migratetype); > - if (unlikely(!is_migrate_isolate(migratetype))) > + if (!is_migrate_isolate(migratetype)) > __mod_zone_freepage_state(zone, 1 << order, migratetype); > spin_unlock(&zone->lock); > } > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>