On Wed, Jul 02, 2014 at 11:44:39AM -0400, Johannes Weiner wrote: > On Tue, Jul 01, 2014 at 05:25:38PM -0400, Johannes Weiner wrote: > > These explanations make no sense. If pages of a streaming writer have > > enough time in memory to not thrash with a single zone, the fair > > policy should make even MORE time in memory available to them and not > > thrash them. The fair policy is a necessity for multi-zone aging to > > make any sense and having predictable reclaim and activation behavior. > > That's why it's obviously not meant to benefit streaming workloads, > > but it shouldn't harm them, either. Certainly not 20%. If streaming > > pages thrash, something is up, the solution isn't to just disable the > > second zone or otherwise work around the issue. > > Hey, funny story. > > I tried reproducing this with an isolated tester just to be sure, > stealing tiobench's do_read_test(), but I wouldn't get any results. > > I compared the original fair policy commit with its parent, I compared > a current vanilla kernel to a crude #ifdef'd policy disabling, and I > compared vanilla to your patch series - every kernel yields 132MB/s. > > Then I realized, 132MB/s is the disk limit anyway - how the hell did I > get 150MB/s peak speeds for sequential cold cache IO with seqreadv4? > > So I looked at the tiobench source code and it turns out, it's not > cold cache at all: it first does the write test, then the read test on > the same file! > > The file is bigger than memory, so you would expect the last X percent > of the file to be cached after the seq write and the subsequent seq > read to push the tail out before getting to it - standard working set > bigger than memory behavior. > > But without fairness, a chunk from the beginning of the file gets > stuck in the DMA32 zone and never pushed out while writing, so when > the reader comes along, it gets random parts from cache! > > All patches that showed "major improvements" ruined fairness and led > to non-linear caching of the test file during the write, and the read > speedups came from the file being partially served from cache. > Well, shit. Yes, artificially preserving would give an apparent boost but be the completely wrong thing to do. Andrew, please drop the series from mmotm. I'll pick apart whatever is left that makes sense and resubmit what's left over if necessary. Thanks -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>