On Mon, Jun 30, 2014 at 02:09:49PM -0700, Hugh Dickins wrote: > Do we really need an exported alias for __SetPageReferenced()? > Its callers better know what they're doing, in which case the page > would not be already marked referenced. Kill init_page_accessed(), > just __SetPageReferenced() inline. > > Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx> Ok, fair enough. The context it was written in was that callers should not need to know the internals of what mark_page_accessed does. Initially I thought there might be filesystem users that really should not know the internals but that is not necessary obviously. I still feel that init_page_accessed shows the intent more clearly and you're certainly right that the checking PageReferenced is redundant. I don't object to the patch but I don't think it's obviously better either other than it avoids the temptation of anyone using __SetPageReferenced incorrectly. Acked-by: Mel Gorman <mgorman@xxxxxxx> -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>