[next:master 138/302] mm/zbud.c:137:6: sparse: symbol 'zbud_zpool_destroy' was not declared. Should it be static?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   070b95becb3dee794bc6e313ec391b598e8664f9
commit: a5eaa8ab0f9c42b8b4c457c15c09b8f9b092ecef [138/302] mm/zpool: update zswap to use zpool
reproduce: make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> mm/zbud.c:137:6: sparse: symbol 'zbud_zpool_destroy' was not declared. Should it be static?
>> mm/zbud.c:142:5: sparse: symbol 'zbud_zpool_malloc' was not declared. Should it be static?
>> mm/zbud.c:146:6: sparse: symbol 'zbud_zpool_free' was not declared. Should it be static?
>> mm/zbud.c:151:5: sparse: symbol 'zbud_zpool_shrink' was not declared. Should it be static?
>> mm/zbud.c:170:6: sparse: symbol 'zbud_zpool_map' was not declared. Should it be static?
>> mm/zbud.c:175:6: sparse: symbol 'zbud_zpool_unmap' was not declared. Should it be static?
>> mm/zbud.c:180:5: sparse: symbol 'zbud_zpool_total_size' was not declared. Should it be static?

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation
From: Fengguang Wu <fengguang.wu@xxxxxxxxx>
Subject: [PATCH next] mm/zpool: zbud_zpool_destroy() can be static
TO: Dan Streetman <ddstreet@xxxxxxxx>
CC: linux-mm@xxxxxxxxx 
CC: linux-kernel@xxxxxxxxxxxxxxx 

CC: Dan Streetman <ddstreet@xxxxxxxx>
Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
---
 zbud.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/mm/zbud.c b/mm/zbud.c
index 645379e..1695c28 100644
--- a/mm/zbud.c
+++ b/mm/zbud.c
@@ -134,21 +134,21 @@ static void *zbud_zpool_create(gfp_t gfp, struct zpool_ops *zpool_ops)
 	return zbud_create_pool(gfp, &zbud_zpool_ops);
 }
 
-void zbud_zpool_destroy(void *pool)
+static void zbud_zpool_destroy(void *pool)
 {
 	zbud_destroy_pool(pool);
 }
 
-int zbud_zpool_malloc(void *pool, size_t size, unsigned long *handle)
+static int zbud_zpool_malloc(void *pool, size_t size, unsigned long *handle)
 {
 	return zbud_alloc(pool, size, handle);
 }
-void zbud_zpool_free(void *pool, unsigned long handle)
+static void zbud_zpool_free(void *pool, unsigned long handle)
 {
 	zbud_free(pool, handle);
 }
 
-int zbud_zpool_shrink(void *pool, unsigned int pages,
+static int zbud_zpool_shrink(void *pool, unsigned int pages,
 			unsigned int *reclaimed)
 {
 	unsigned int total = 0;
@@ -167,17 +167,17 @@ int zbud_zpool_shrink(void *pool, unsigned int pages,
 	return ret;
 }
 
-void *zbud_zpool_map(void *pool, unsigned long handle,
+static void *zbud_zpool_map(void *pool, unsigned long handle,
 			enum zpool_mapmode mm)
 {
 	return zbud_map(pool, handle);
 }
-void zbud_zpool_unmap(void *pool, unsigned long handle)
+static void zbud_zpool_unmap(void *pool, unsigned long handle)
 {
 	zbud_unmap(pool, handle);
 }
 
-u64 zbud_zpool_total_size(void *pool)
+static u64 zbud_zpool_total_size(void *pool)
 {
 	return zbud_get_pool_size(pool) * PAGE_SIZE;
 }

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]