On Sat, 21 Jun 2014, Jeff Liu wrote: > >> > > > > Bullshit. Read the above. > ^^^^^^^ > I assume that you spoke like that because I have not reply to you in time, I can > understand if so. Otherwise, don't talk to me like that no matter who you are! Ignore his BS. You already posted the patches that did what he asked for. Lets go back to that one. I am reversing my reversal. Sorry about that. > > If you want to return PTR_ERR() when this fails and fixup all the callers, > > then propose that patch. Until then, it's a pretty simple rule: if you > > don't have an errno, don't assume the reason for failure. > > As I mentioned previously, Greg don't like to fixup kobjects API via PTR_ERR(). > For me, I neither want to propose PTR_ERR to kobject nor try to push the current > slub fix, because it's make no sense to slub with either errno. Lets ignore Greg's incorrect assessment and do what Andrew suggested. I prefer to have clean error code passing. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>