On Mon, Jun 16, 2014 at 03:27:19PM +0900, Minchan Kim wrote: > Hi, Joonsoo > > On Mon, Jun 16, 2014 at 02:40:43PM +0900, Joonsoo Kim wrote: > > We should free memory for bitmap when we find zone mis-match, > > otherwise this memory will leak. > > > > Additionally, I copy code comment from PPC KVM's CMA code to inform > > why we need to check zone mis-match. > > > > * Note > > Minchan suggested to add a tag for the stable, but, I don't do it, > > because I found this possibility during code-review and, IMO, > > this patch isn't suitable for stable tree. > > Nice idea to put the comment in here. Thanks Joonsoo. > > It seems you obey "It must fix a real bug that bothers people" > on Documentation/stable_kernel_rules.txt but it's a really obvious > bug and hard to get a report from people because limited user and > hard to detect small such small memory leak. > > In my experince, Andrew perfered stable marking for such a obvious > problem but simple fix like this but not sure so let's pass the decision > to him and will learn a lesson from him and will follow the decision > from now on. Yes, I intended to pass the decision to others. :) > > Thanks. > > Acked-by: Minchan Kim <minchan@xxxxxxxxxx> Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>