On 06/16/2014 22:00 PM, Christoph Lameter wrote: > On Sat, 14 Jun 2014, Jeff Liu wrote: > >> Thanks for your clarification and sorry for the noise. > > Dont be worried. I am not sure anymore that this was such a wise move. > Maybe get kset_create_and_add to return an error code instead and return > that instead of -ENOSYS? Personally, I prefer to get kset_create_and_add() to return an error which can reflect the actual cause of the failure given that kset_register() can failed due to different reasons. If so, however, looks we have to make a certain amount of change for the existing modules which are support sysfs since they all return -ENOMEM if kset_create_and_add() return NULL, maybe this is inherited from samples/kobject/kset-example.c... Cheers, -Jeff -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>