On Thu, 2014-06-12 at 08:45 -0400, Rik van Riel wrote: > > shrink_page_list() has too many arguments that have already reached > ten. > > Some of those arguments and temporary variables introduces extra 80 > bytes > > on the stack. > > > > This patch wraps five parameters into arg_container and removes some > temporary > > variables, thus making shrink_page_list() to consume fewer stack > space. > > Won't the container with those arguments now live on the stack, > using up the same space that the variables used to take? > Of course, the container with those arguments live on the stack. One of the key reason for introducing this patch is to avoid passing five pointer arguments to shrink_page_list(). The arg_container also uses up the same space that the variables used to take. If the those arguments is wrapped to arg_container, we just need to pass one pointer to shrink_page_list instead of five. thx! cyc -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>