On Wed, 11 Jun 2014, Vlastimil Babka wrote: > > > diff --git a/mm/compaction.c b/mm/compaction.c > > > index c339ccd..d1e30ba 100644 > > > --- a/mm/compaction.c > > > +++ b/mm/compaction.c > > > @@ -965,8 +965,8 @@ static isolate_migrate_t isolate_migratepages(struct > > > zone *zone, > > > return ISOLATE_SUCCESS; > > > } > > > > > > -static int compact_finished(struct zone *zone, > > > - struct compact_control *cc) > > > +static int compact_finished(struct zone *zone, struct compact_control > > > *cc, > > > + const int migratetype) > > > > If we has gfp_mask, we could use gfpflags_to_migratetype from cc->gfp_mask. > > What's is your intention? > > Can't speak for David but I left it this way as it means > gfpflags_to_migratetype is only called once per compact_zone. Now I realize my > patch 10/10 repeats the call in isolate_migratepages_range so I'll probably > update that as well. > Yes, that was definitely the intention: call it once in compact_zone() and store it as const and then avoid calling it every time for compact_finished(). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>