On 06/05/2014 01:31 AM, Dave Jones wrote:
> I just noticed that trinity was freaking out in places when mmap was
> returning zero. This surprised me, because I had the mmap_min_addr
> sysctl set to 64k, so it wasn't a MAP_FIXED mapping that did it.
>
> There's no mention of this return value in the man page, so I dug
> into the kernel code, and it appears that we do..
>
> sys_mmap
> vm_mmap_pgoff
> security_mmap_file
> ima_file_mmap <- returns 0 if not PROT_EXEC
>
> and then the 0 gets propagated up as a retval all the way to userspace.
>
> It smells to me like we might be violating a standard or two here, and
> instead of 0 ima should be returning -Esomething
>
> thoughts?
Seems like either EACCESS or ENOTSUP is appropriate; here's the pieces
from POSIX:
EACCES The fildes argument is not open for read, regardless of
the protection specified, or fildes is not open for
write and PROT_WRITE was specified for a MAP_SHARED type
mapping.
ENOTSUP
The implementation does not support the combination
of accesses requested in the prot argument.
ENOTSUP seems to be more appropriate in my reading of the above, though
I'd somehow more have expected EACCES.
Cheers,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>