Re: [PATCH 1/3] memory-failure: Send right signal code to correct thread

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 02, 2014 at 03:44:31PM -0700, Andrew Morton wrote:
> On Fri, 30 May 2014 02:51:08 -0400 Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> wrote:
> 
> > From: Tony Luck <tony.luck@xxxxxxxxx>
> > 
> > When a thread in a multi-threaded application hits a machine
> > check because of an uncorrectable error in memory - we want to
> > send the SIGBUS with si.si_code = BUS_MCEERR_AR to that thread.
> > Currently we fail to do that if the active thread is not the
> > primary thread in the process. collect_procs() just finds primary
> > threads and this test:
> > 	if ((flags & MF_ACTION_REQUIRED) && t == current) {
> > will see that the thread we found isn't the current thread
> > and so send a si.si_code = BUS_MCEERR_AO to the primary
> > (and nothing to the active thread at this time).
> > 
> > We can fix this by checking whether "current" shares the same
> > mm with the process that collect_procs() said owned the page.
> > If so, we send the SIGBUS to current (with code BUS_MCEERR_AR).
> > 
> > Reported-by: Otto Bruggeman <otto.g.bruggeman@xxxxxxxxx>
> > Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
> > Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>
> > Cc: Borislav Petkov <bp@xxxxxxx>
> > Cc: Chen Gong <gong.chen@xxxxxxxxxxxxxxxxxx>
> > Acked-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>
> 
> You were on the patch delivery path, so it should have included your
> signed-off-by.  Documentation/SubmittingPatches section 12 has the
> details.

Sorry, I didn't know that.

> I have made that change to my copies of patches 1 and 2.

Thank you.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]