On 06/01/2014 10:24 PM, Naoya Horiguchi wrote: > -#define PAGECACHE_TAG_DIRTY 0 > -#define PAGECACHE_TAG_WRITEBACK 1 > -#define PAGECACHE_TAG_TOWRITE 2 > +enum { > + PAGECACHE_TAG_DIRTY, > + PAGECACHE_TAG_WRITEBACK, > + PAGECACHE_TAG_TOWRITE, > + __NR_PAGECACHE_TAGS, > +}; Doesn't this end up exposing kernel-internal values out to a userspace interface? Wouldn't that lock these values in to the ABI? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>