On Fri, 30 May 2014, Vladimir Davydov wrote: > First, nobody uses it. Second, it differs across the implementations: > for SLUB it always returns 0, for SLAB it returns 0 if the cache appears > to be empty. So let's get rid of it. Well slub returns an error code if it fails. I am all in favor of making it consistent. The indication in SLAB that the slab is empty may be useful. May return error code or the number of slab pages in use? Some of the code that is shared by the allocators here could be moved into mm/slab_common.c. Put kmem_cache_shrink there and then have __kmem_cache_shrink to the allocator specific things? x -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>