On Thu, 22 May 2014, Vladimir Davydov wrote: > On Wed, May 21, 2014 at 07:13:21PM -0500, Christoph Lameter wrote: > > On Wed, 21 May 2014, Vladimir Davydov wrote: > > > > > Do I understand you correctly that the following change looks OK to you? > > > > Almost. Preemption needs to be enabled before functions that invoke the > > page allocator etc etc. > > I need to disable preemption only in slab_free, which never blocks > according to its semantics, so everything should be fine just like that. slab_free calls __slab_free which can release slabs via put_cpu_partial()/unfreeze_partials()/discard_slab() to the page allocator. I'd rather have preemption enabled there. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>