On Mon, May 12, 2014 at 05:45:31PM +0200, Vlastimil Babka wrote:
...
> >>+/*
> >>+ * Similar to compact_checklock_irqsave() (see its comment) for places where
> >>+ * a zone lock is not concerned.
> >>+ *
> >>+ * Returns false when compaction should abort.
> >>+ */
> >>+static inline bool compact_check_resched(struct compact_control *cc)
> >>+{
> >>+ /* async compaction aborts if contended */
> >>+ if (need_resched()) {
> >>+ if (cc->mode == MIGRATE_ASYNC) {
> >>+ cc->contended = true;
> >
> >This changes the meaning of contended in struct compact_control (not just
> >indicating lock contention,) so please update the comment in mm/internal.h too.
>
> It doesn't change it, since compact_checklock_irqsave() already has
> this semantic:
> if (should_release_lock(lock) && cc->mode == MIGRATE_ASYNC)
> cc->contended = true;
>
> and should_release_lock() is:
> need_resched() || spin_is_contended(lock)
>
> So the comment was already outdated, I will update it in v2.
Ah OK. Sorry for falsely blaming you :)
Naoya
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>