On Wed, 7 May 2014 03:36:46 -0700 (PDT) David Rientjes <rientjes@xxxxxxxxxx> wrote: > We're going to want to manipulate the migration mode for compaction in the page > allocator, and currently compact_control's sync field is only a bool. > > Currently, we only do MIGRATE_ASYNC or MIGRATE_SYNC_LIGHT compaction depending > on the value of this bool. Convert the bool to enum migrate_mode and pass the > migration mode in directly. Later, we'll want to avoid MIGRATE_SYNC_LIGHT for > thp allocations in the pagefault patch to avoid unnecessary latency. > > This also alters compaction triggered from sysfs, either for the entire system > or for a node, to force MIGRATE_SYNC. mm/page_alloc.c: In function 'alloc_contig_range': mm/page_alloc.c:6255: error: unknown field 'sync' specified in initializer --- a/mm/page_alloc.c~mm-compaction-embed-migration-mode-in-compact_control-fix +++ a/mm/page_alloc.c @@ -6252,7 +6252,7 @@ int alloc_contig_range(unsigned long sta .nr_migratepages = 0, .order = -1, .zone = page_zone(pfn_to_page(start)), - .sync = MIGRATE_SYNC_LIGHT, + .mode = MIGRATE_SYNC_LIGHT, .ignore_skip_hint = true, }; INIT_LIST_HEAD(&cc.migratepages); Please check that you sent the correct version of this? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>