On Fri, 9 May 2014, Jianyu Zhan wrote: > mlocked_vma_newpage() is only called in fault path by > page_add_new_anon_rmap(), which is called on a *new* page. > And such page is initially only visible via the pagetables, and the > pte is locked while calling page_add_new_anon_rmap(), so we could use > a irq-safe version of __mod_zone_page_state() here. You are changing from the irq safe variant to __mod_zone_page_state which is *not* irq safe. Its legit to do so since presumably irqs are disabled anyways so you do not have to worry about irq safeness of __mod_zone_page_state. Please update the description. Its a bit confusing right now. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>