Re: [RFC, PATCH 0/8] remap_file_pages() decommission

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 7 May 2014 02:03:23 +0300 "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx> wrote:

> remap_file_pages(2) was invented to be able efficiently map parts of
> huge file into limited 32-bit virtual address space such as in database
> workloads.
> 
> Nonlinear mappings are pain to support and it seems there's no
> legitimate use-cases nowadays since 64-bit systems are widely available.
> 
> Let's deprecate remap_file_pages() syscall in hope to get rid of code
> one day.

Before we do this we should ensure that your proposed replacement is viable
and desirable.  If we later decide not to proceed with it, this patch will
sow confusion.

> --- a/mm/fremap.c
> +++ b/mm/fremap.c
> @@ -152,6 +152,9 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size,
>  	int has_write_lock = 0;
>  	vm_flags_t vm_flags = 0;
>  
> +	printk_once(KERN_WARNING "%s (%d) uses depricated "

pr_warn_once(), "deprecated".

> +			"remap_file_pages(2) syscall.\n",
> +			current->comm, current->pid);
>  	if (prot)
>  		return err;

Can we provide more info than this?  Why is it deprecated, what do we
plan to do with it, what are people's options, etc?  Add "See
Documentation/remap_file_pages.txt", perhaps.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]