On Thu 10-04-14 10:27:29, Matthew Wilcox wrote: > On Wed, Apr 09, 2014 at 12:15:12PM +0200, Jan Kara wrote: > > > + /* > > > + * ext4 sometimes asks to zero past the end of a block. It > > > + * really just wants to zero to the end of the block. > > > + */ > > Then we should really fix ext4 I believe... > > Since I didn't want to do this ... > > > > +/* Can't be a function because PAGE_CACHE_SIZE is defined in pagemap.h */ > > > +#define dax_truncate_page(inode, from, get_block) \ > > > + dax_zero_page_range(inode, from, PAGE_CACHE_SIZE, get_block) > > ^^^^ > > This should be (PAGE_CACHE_SIZE - (from & (PAGE_CACHE_SIZE - 1))), shouldn't it? > > ... I could get away without doing that ;-) I understand but ultimately the API is cleaner if it doesn't allow size past end of block. So IMHO we shouldn't introduce new places that call the function like this and we should fix places that do it now (make it WARN_ON_ONCE() and let ext4 guys do the work for you ;). Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>