On Mon 31-03-14 13:09:31, Andrew Morton wrote:
> On Mon, 31 Mar 2014 00:50:04 +0800 kbuild test robot <fengguang.wu@xxxxxxxxx> wrote:
>
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: 201544be8c37dffbf069bb5fc9edb5674f8c1754
> > commit: a35f174ec04eaf07a52bb0603ecbb332450d6b4e [15/486] fanotify: use fanotify event structure for permission response processing
> > config: x86_64-randconfig-c0-0331 (attached as .config)
> >
> > Note: the next/master HEAD 201544be8c37dffbf069bb5fc9edb5674f8c1754 builds fine.
> > It only hurts bisectibility.
> >
> > All error/warnings:
> >
> > fs/notify/fanotify/fanotify_user.c: In function 'copy_event_to_user':
> > >> fs/notify/fanotify/fanotify_user.c:214:23: error: 'struct fsnotify_event' has no member named 'fae'
> > list_add_tail(&event->fae.fse.list,
> > ^
> >
> > vim +214 fs/notify/fanotify/fanotify_user.c
> >
> > 208 goto out_close_fd;
> > 209
> > 210 #ifdef CONFIG_FANOTIFY_ACCESS_PERMISSIONS
> > 211 if (event->mask & FAN_ALL_PERM_EVENTS) {
> > 212 FANOTIFY_PE(event)->fd = fd;
> > 213 mutex_lock(&group->fanotify_data.access_mutex);
> > > 214 list_add_tail(&event->fae.fse.list,
> > 215 &group->fanotify_data.access_list);
> > 216 mutex_unlock(&group->fanotify_data.access_mutex);
> > 217 }
>
> This, I suppose.
Yup, that looks good. Thanks for fixing it up so quickly.
Honza
> --- a/fs/notify/fanotify/fanotify_user.c~fanotify-use-fanotify-event-structure-for-permission-response-processing-fix
> +++ a/fs/notify/fanotify/fanotify_user.c
> @@ -209,9 +209,12 @@ static ssize_t copy_event_to_user(struct
>
> #ifdef CONFIG_FANOTIFY_ACCESS_PERMISSIONS
> if (event->mask & FAN_ALL_PERM_EVENTS) {
> - FANOTIFY_PE(event)->fd = fd;
> + struct fanotify_perm_event_info *pevent;
> +
> + pevent = FANOTIFY_PE(event);
> + pevent->fd = fd;
> mutex_lock(&group->fanotify_data.access_mutex);
> - list_add_tail(&event->fae.fse.list,
> + list_add_tail(&pevent->fae.fse.list,
> &group->fanotify_data.access_list);
> mutex_unlock(&group->fanotify_data.access_mutex);
> }
> _
>
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>