On Sat, Mar 15, 2014 at 01:22:53PM -0700, dbasehore . wrote: > mod_delayed_work currently removes a work item from a workqueue if it > is on it. Correct me if I'm wrong, but I don't think that this is > necessarily required for mod_delayed_work to have the current > behavior. We should be able to set the timer while a delayed_work is > currently on a workqueue. If the delayed_work is still on the > workqueue when the timer goes off, everything is fine. If it has left > the workqueue, we can queue it again. What different would that make w.r.t. this issue? Plus, please note that a work item may wait non-insignificant amount of time pending if the workqueue is saturated to max_active. Doing the above would make mod_delayed_work()'s behavior quite fuzzy - the work item is modified or queued to the specified time but if the timer has already expired, the work item may execute after unspecified amount of time which may be shorter than the new timeout. What kind of interface would that be? Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>