On Tue 11-03-14 21:28:29, Johannes Weiner wrote: [...] > @@ -3919,20 +3919,21 @@ out: > return ret; > } > > -/* > - * Charge the memory controller for page usage. > - * Return > - * 0 if the charge was successful > - * < 0 if the cgroup is over its limit > - */ > -static int mem_cgroup_charge_common(struct page *page, struct mm_struct *mm, > - gfp_t gfp_mask, enum charge_type ctype) > +int mem_cgroup_newpage_charge(struct page *page, > + struct mm_struct *mm, gfp_t gfp_mask) s/mem_cgroup_newpage_charge/mem_cgroup_anon_charge/ ? Would be a better name? The patch would be bigger but the name more apparent... Other than that I am good with this. Without (preferably) or without rename: Acked-by: Michal Hocko <mhocko@xxxxxxx> -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>