Re: [PATCH] mm: implement POSIX_FADV_NOREUSE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/11/2014 07:06 AM, Michal Hocko wrote:
>> > In our implementation pages marked with the NoReuse flag are added to
>> > the tail of the LRU list the first time they are read. Therefore they
>> > are the first to be reclaimed.
> page flags are really scarce and I am not sure this is the best usage of
> the few remaining slots.

Yeah, especially since the use so so transient.  I can see why using a
flag is nice for a quick prototype, but this is a far cry from needing
one. :)  You might be able to reuse a bit like PageReadahead.  You could
probably also use a bit in the page pointer of the lruvec, or even have
a percpu variable that stores a pointer to the 'struct page' you want to
mark as NOREUSE.

This also looks to ignore the reuse flag for existing pages.  Have you
thought about what the semantics should be there?

Also, *should* readahead pages really have this flag set?  If a very
important page gets brought in via readahead, doesn't this put it at a
disadvantage for getting aged out?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]