Re: slub: fix leak of 'name' in sysfs_slab_add

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 07, 2014 at 10:18:04AM +0400, Vladimir Davydov wrote:
 > [adding Andrew to Cc]
 > 
 > On 03/07/2014 01:11 AM, Dave Jones wrote:
 > > The failure paths of sysfs_slab_add don't release the allocation of 'name'
 > > made by create_unique_id() a few lines above the context of the diff below.
 > > Create a common exit path to make it more obvious what needs freeing.
 > > 
 > > Signed-off-by: Dave Jones <davej@xxxxxxxxxxxxxxxxx>
 > > 
 > 
 > Since this function was modified in the mmotm tree, I would propose
 > something like this on top of mmotm to avoid further merge conflicts:
 
Looks good to me.

thanks,

	Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]