On Thu, 2014-03-06 at 16:16 -0800, Davidlohr Bueso wrote: > On Wed, 2014-03-05 at 16:45 -0800, Dave Hansen wrote: > > From: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> > > > > The > > > > if (cpumask_any_but(mm_cpumask(mm), smp_processor_id()) < nr_cpu_ids) > > > > line of code is not exactly the easiest to audit, especially when > > it ends up at two different indentation levels. This eliminates > > one of the the copy-n-paste versions. It also gives us a unified > > exit point for each path through this function. We need this in > > a minute for our tracepoint. > > > > > > Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> > > --- > > > > b/arch/x86/mm/tlb.c | 23 +++++++++++------------ > > 1 file changed, 11 insertions(+), 12 deletions(-) > > > > diff -puN arch/x86/mm/tlb.c~simplify-tlb-code arch/x86/mm/tlb.c > > --- a/arch/x86/mm/tlb.c~simplify-tlb-code 2014-03-05 16:10:09.607047728 -0800 > > +++ b/arch/x86/mm/tlb.c 2014-03-05 16:10:09.610047866 -0800 > > @@ -161,23 +161,24 @@ void flush_tlb_current_task(void) > > void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, > > unsigned long end, unsigned long vmflag) > > { > > + int need_flush_others_all = 1; > > nit: this can be bool. never mind, you get rid of it later. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>