On Wed, 2014-03-05 at 19:54 -0800, Andrew Morton wrote: > On Wed, 05 Mar 2014 19:46:17 -0800 Davidlohr Bueso <davidlohr@xxxxxx> wrote: > > > On Thu, 2014-03-06 at 11:24 +0800, kbuild test robot wrote: > > > tree: git://git.cmpxchg.org/linux-mmotm.git master > > > head: f6bf2766c2091cbf8ffcc2c5009875dbdb678282 > > > commit: 88a76abced8c721ac726ea6a273ed0389b1c5ff4 [188/471] mm: per-thread vma caching > > > config: make ARCH=sparc defconfig > > > > > > All error/warnings: > > > > > > In file included from arch/sparc/include/asm/pgtable_32.h:17:0, > > > from arch/sparc/include/asm/pgtable.h:6, > > > from include/linux/mm.h:51, > > > from include/linux/vmacache.h:4, > > > from include/linux/sched.h:26, > > > from arch/sparc/kernel/asm-offsets.c:13: > > > include/linux/swap.h: In function 'current_is_kswapd': > > > >> include/linux/swap.h:33:16: error: dereferencing pointer to incomplete type > > > >> include/linux/swap.h:33:26: error: 'PF_KSWAPD' undeclared (first use in this function) > > > include/linux/swap.h:33:26: note: each undeclared identifier is reported only once for each function it appears in > > > make[2]: *** [arch/sparc/kernel/asm-offsets.s] Error 1 > > > make[2]: Target `__build' not remade because of errors. > > > make[1]: *** [prepare0] Error 2 > > > make[1]: Target `prepare' not remade because of errors. > > > make: *** [sub-make] Error 2 > > > > > > vim +33 include/linux/swap.h > > > > I knew something like this was gonna happen with the whole header file > > thing. Andrew, would you prefer getting rid of vmacache.h and just > > sticking the contents in mm.h? I was hoping not to do that, but if it > > causes a lot of pain then the hell with it. > > My usual approach to this sort of thing is to go finer-grained, so it > cannot happen again. ie: move all the PF_foo definitions into their > own little header. I assume this will fix it. > > I'll take care of doing that. Thanks, let me know if you need anything from my end. Also, Fengguang's bot is going crazy on this so not sure how straightforward any other kind of fix might be: https://lists.01.org/pipermail/kbuild-all/2014-March/003442.html (sparc) https://lists.01.org/pipermail/kbuild-all/2014-March/003445.html (s390) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>