Hi Andrew, On Tue, 4 Mar 2014 13:26:04 -0800 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Sun, 2 Mar 2014 19:09:58 +0530 Gideon Israel Dsouza <gidisrael@xxxxxxxxx> wrote: > > > To increase compiler portability there is <linux/compiler.h> which > > provides convenience macros for various gcc constructs. Eg: __weak > > for __attribute__((weak)). I've replaced all instances of gcc > > attributes with the right macro in the memory management > > (/mm) subsystem. > > > > ... > > > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -13,6 +13,7 @@ > > #include <linux/nodemask.h> > > #include <linux/pagemap.h> > > #include <linux/mempolicy.h> > > +#include <linux/compiler.h> > > It may be overdoing things a bit to explicitly include compiler.h. > It's hard to conceive of any .c file which doesn't already include it. Stick to Rule 1 :-) -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
Attachment:
pgpdCYRPghVb9.pgp
Description: PGP signature