On Fri, Feb 14, 2014 at 12:49:57PM -0600, Christoph Lameter wrote: > On Fri, 14 Feb 2014, Joonsoo Kim wrote: > > > @@ -921,7 +784,7 @@ static int transfer_objects(struct array_cache *to, > > static inline struct alien_cache **alloc_alien_cache(int node, > > int limit, gfp_t gfp) > > { > > - return (struct alien_cache **)BAD_ALIEN_MAGIC; > > + return NULL; > > } > > > > Why change the BAD_ALIEN_MAGIC? Hello, Christoph. BAD_ALIEN_MAGIC is only checked by slab_set_lock_classes(). We remove this function in this patch, so returning BAD_ALIEN_MAGIC is useless. And, in fact, BAD_ALIEN_MAGIC is already useless, because alloc_alien_cache() can't be called on !CONFIG_NUMA. This function is called if use_alien_caches is positive, but on !CONFIG_NUMA, use_alien_caches is always 0. So we don't have any chance to meet this BAD_ALIEN_MAGIC in runtime. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>