On 02/07/2014 06:08 AM, Joonsoo Kim wrote:
> It is just for clean-up to reduce code size and improve readability.
> There is no functional change.
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 985b782..7a4e3b7 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -554,11 +554,7 @@ isolate_migratepages_range(struct zone *zone, struct compact_control *cc,
> if (unlikely(balloon_page_movable(page))) {
> if (locked && balloon_page_isolate(page)) {
> /* Successfully isolated */
> - cc->finished_update_migrate = true;
> - list_add(&page->lru, migratelist);
> - cc->nr_migratepages++;
> - nr_isolated++;
> - goto check_compact_cluster;
> + goto isolate_success;
> }
> }
> continue;
> @@ -610,13 +606,14 @@ isolate_migratepages_range(struct zone *zone, struct compact_control *cc,
> VM_BUG_ON(PageTransCompound(page));
>
> /* Successfully isolated */
> - cc->finished_update_migrate = true;
> del_page_from_lru_list(page, lruvec, page_lru(page));
> +
> +isolate_success:
> + cc->finished_update_migrate = true;
> list_add(&page->lru, migratelist);
> cc->nr_migratepages++;
> nr_isolated++;
>
> -check_compact_cluster:
> /* Avoid isolating too much */
> if (cc->nr_migratepages == COMPACT_CLUSTER_MAX) {
> ++low_pfn;
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>