Quoting Sebastian Capella (2014-02-04 14:37:33) > Quoting Rafael J. Wysocki (2014-02-04 13:36:29) > > > static int __init resumedelay_setup(char *str) > > > { > > > - resume_delay = simple_strtoul(str, NULL, 0); > > > + int ret = kstrtoint(str, 0, &resume_delay); > > > + /* mask must_check warn; on failure, leaves resume_delay unchanged */ > > > + (void)ret; One unintended consequence of this change is that it'll now accept a negative integer parameter. I'll rework this to have the same behavior as before. BTW, one question, is the __must_check really needed on kstrtoint? Wouldn't it be acceptable to rely on kstrtoint to not update resume_delay if it's unable to parse an integer out of the string? Couldn't that be a sufficient effect without requiring checking the return? Thanks, Sebastian -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href