Re: [PATCH] memcg: fix mutex not unlocked on memcg_create_kmem_cache fail path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 30 Jan 2014 14:13:18 -0800 (PST) David Rientjes <rientjes@xxxxxxxxxx> wrote:

> On Thu, 30 Jan 2014, Andrew Morton wrote:
> 
> > > Why?  We already construct the name in memcg_create_kmem_cache() 
> > > appropriately, we just want to avoid the kstrdup() in 
> > > kmem_cache_create_memcg() since it's pointless like my patch does.
> > 
> > oh, OK, missed that.
> > 
> > The problem now is that the string at kmem_cache.name is PATH_MAX
> > bytes, and PATH_MAX is huuuuuuuge.
> > 
> 
> It always was.

eh?  kmem_cache_create_memcg()'s kstrdup() will allocate the minimum
needed amount of memory.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]