On Tue, 28 Jan 2014, Nishanth Aravamudan wrote: > In the presence of memoryless nodes, numa_node_id()/cpu_to_node() will > return the current CPU's NUMA node, but that may not be where we expect > to allocate from memory from. Instead, we should use > numa_mem_id()/cpu_to_mem(). On one ppc64 system with a memoryless Node > 0, this ends up saving nearly 500M of slab due to less fragmentation. > > Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxxxxxxxxxx> Acked-by: David Rientjes <rientjes@xxxxxxxxxx> > diff --git a/kernel/kthread.c b/kernel/kthread.c > index b5ae3ee..8573e4e 100644 > --- a/kernel/kthread.c > +++ b/kernel/kthread.c > @@ -217,7 +217,7 @@ int tsk_fork_get_node(struct task_struct *tsk) > if (tsk == kthreadd_task) > return tsk->pref_node_fork; > #endif > - return numa_node_id(); > + return numa_mem_id(); I'm wondering why return NUMA_NO_NODE wouldn't have the same effect and prefer the local node? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>