On Thu, Jan 23, 2014 at 07:14:45PM +0400, Cyrill Gorcunov wrote: > On Thu, Jan 23, 2014 at 04:55:43PM +0400, Cyrill Gorcunov wrote: > > On Thu, Jan 23, 2014 at 04:15:55PM +0400, Cyrill Gorcunov wrote: > > > > > > > > Thanks a lot, Mel! I'm testing the patch as well (manually though :). > > > > I'll send the final fix today. > > > > > > The patch below should fix the problem. I would really appreaciate > > > some additional testing. > > > > Forgot to refresh the patch, sorry. > > --- > > I think setting up dirty bit inside vma_merge() body is a big hammer > which should not be used, but it's up to caller of vma_merge() to figure > out if dirty bit should be set or not if merge successed. Thus softdirty > vma bit should be (and it already is) set at the end of mmap_region and do_brk > routines. So patch could be simplified (below). Pavel, what do you think? > --- > From: Cyrill Gorcunov <gorcunov@xxxxxxxxx> > Subject: [PATCH] mm: Ignore VM_SOFTDIRTY on VMA merging, v2 > It passed the gimp launching test. Patch looks sane but I confess I did not put a whole lot of thought into it because I see that Andrew is already reviewing it so Tested-by: Mel Gorman <mgorman@xxxxxxx> If this is merged then remember that it should be tagged for 3.12-stable as 3.12.7 and 3.12.8 are affected by this bug. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>