On Wed, Jan 22, 2014 at 3:33 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > On Wed, 22 Jan 2014 09:19:58 -0500 Dan Streetman <ddstreet@xxxxxxxx> wrote: > >> >>> > Acutally, I really don't know how much benefit we have that in-memory >> >>> > swap overcomming to the real storage but if you want, zRAM with dm-cache >> >>> > is another option rather than invent new wheel by "just having is better". >> >>> >> >>> I'm not sure if this patch is related to the zswap vs. zram discussions. This >> >>> only adds the option of using writethrough to zswap. It's a first >> >>> step to possibly >> >>> making zswap work more efficiently using writeback and/or writethrough >> >>> depending on >> >>> the system and conditions. >> >> >> >> The patch size is small. Okay I don't want to be a party-pooper >> >> but at least, I should say my thought for Andrew to help judging. >> > >> > Sure, I'm glad to have your suggestions. >> >> To give this a bump - Andrew do you have any concerns about this >> patch? Or can you pick this up? > > I don't pay much attention to new features during the merge window, > preferring to shove them into a folder to look at later. Often they > have bitrotted by the time -rc1 comes around. > > I'm not sure that this review discussion has played out yet - is > Minchan happy? I think so, or at least ok enough to not block it, but please correct me if I am wrong, Minchan. > > Please update the changelog so that it reflects the questions Minchan > asked (any reviewer question should be regarded as an inadequacy in > either the code commenting or the changelog - people shouldn't need to > ask the programmer why he did something!) and resend for -rc1? OK I'll update and resend. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>