On Mon, Jan 20, 2014 at 03:31:57PM -0800, Tim Chen wrote: > On Mon, 2014-01-20 at 13:30 +0100, Peter Zijlstra wrote: > > Then again, people seem to whinge if you don't keep these Kbuild files > > sorted, but manually sorting 29 files is just not something I like to > > do. > Can you clarify what exactly needs to be sorted? The Kbuild files > spit out by git diff appears to be sorted already. > > diff --git a/arch/alpha/include/asm/Kbuild b/arch/alpha/include/asm/Kbuild > > index f01fb505ad52..14cbbbcec01f 100644 > > --- a/arch/alpha/include/asm/Kbuild > > +++ b/arch/alpha/include/asm/Kbuild > > @@ -4,3 +4,4 @@ generic-y += clkdev.h > > generic-y += exec.h > > generic-y += trace_clock.h > > generic-y += preempt.h > > +generic-y += mcs_spinlock.h Last time I checked the Alphabet m came before p. I generated this patch using: for i in arch/*/include/asm/Kbuild do echo "generic-y += mcs_spinlock.h" >> $i done Which simply appends the new header. However people want these generic-y thingies sorted by header name. Hence the gawk script I sent which does just that. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>