On Tue, 14 Jan 2014, Nathan Zimmer wrote:
> We don't need to do register_memory_resource() since it has its own lock and
> doesn't make any callbacks.
>
We need to do it, just not under lock_memory_hotplug() :).
> Also register_memory_resource return NULL on failure so we don't have anything
> to cleanup at this point.
>
>
> The reason for this rfc is I was doing some experiments with hotplugging of
> memory on some of our larger systems. While it seems to work, it can be quite
> slow. With some preliminary digging I found that lock_memory_hotplug is
> clearly ripe for breakup.
>
> It could be broken up per nid or something but it also covers the
> online_page_callback. The online_page_callback shouldn't be very hard to break
> out.
>
> Also there is the issue of various structures(wmarks come to mind) that are
> only updated under the lock_memory_hotplug that would need to be dealt with.
>
>
> cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> cc: Tang Chen <tangchen@xxxxxxxxxxxxxx>
> cc: Wen Congyang <wency@xxxxxxxxxxxxxx>
> cc: Kamezawa Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> cc: Yasuaki Ishimatsu <isimatu.yasuaki@xxxxxxxxxxxxxx>
> cc: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>
> cc: Hedi <hedi@xxxxxxx>
> cc: Mike Travis <travis@xxxxxxx>
> cc: linux-mm@xxxxxxxxx
> cc: linux-kernel@xxxxxxxxxxxxxxx
Looks like you're modifying a pre-3.12 kernel version that doesn't have
27356f54c8c3 ("mm/hotplug: verify hotplug memory range").
When your patch is signed off, feel free to add
Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>