Re: [PATCH] shmem: init on stack vmas

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/13/2014 10:46 AM, Josef Bacik wrote:
> We were hitting a weird bug with our cgroup stuff because shmem uses on stack
> vmas.  These aren't properly init'ed so we'd have garbage in vma->mm and bad
> things would happen.  Fix this by just init'ing to empty structs.  Thanks,
...
>  static struct page *shmem_swapin(swp_entry_t swap, gfp_t gfp,
>  			struct shmem_inode_info *info, pgoff_t index)
>  {
> -	struct vm_area_struct pvma;
> +	struct vm_area_struct pvma = {};

What does that code do if it needs an mm and doesn't find one?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]