On Sunday 12 January 2014 10:42 AM, Santosh Shilimkar wrote: > On Sunday 12 January 2014 05:59 AM, Russell King - ARM Linux wrote: >> On Mon, Dec 09, 2013 at 08:02:30PM -0500, Santosh Shilimkar wrote: >>> On Monday 09 December 2013 07:54 PM, Russell King - ARM Linux wrote: >>>> The underlying reason is that - as I've already explained - ARM's __ffs() >>>> differs from other architectures in that it ends up being an int, whereas >>>> almost everyone else is unsigned long. >>>> >>>> The fix is to fix ARMs __ffs() to conform to other architectures. >>>> >>> I was just about to cross-post your reply here. Obviously I didn't think >>> this far when I made $subject fix. >>> >>> So lets ignore the $subject patch which is not correct. Sorry for noise >> >> Well, here we are, a month on, and this still remains unfixed despite >> my comments pointing to what the problem is. So, here's a patch to fix >> this problem the correct way. I took the time to add some comments to >> these functions as I find that I wonder about their return values, and >> these comments make the patch a little larger than it otherwise would be. >> > The $subject warning fix [1] is already picked by Andrew with your ack > and its in his queue [2] > >> This patch makes their types match exactly with x86's definitions of >> the same, which is the basic problem: on ARM, they all took "int" values >> and returned "int"s, which leads to min() in nobootmem.c complaining. >> > Not sure if you missed the thread but the right fix was picked. Ofcourse > you do have additional clz optimisation in updated patch and some comments > on those functions. > > Regards, > Santosh > > [1] https://lkml.org/lkml/2013/12/9/811 fixing the link since above was the link to the $subject thread and below is the correct link for updated patch [1] https://lkml.org/lkml/2013/12/20/497 > [2] http://ozlabs.org/~akpm/mmotm/broken-out/mm-arm-fix-arms-__ffs-to-conform-to-avoid-warning-with-no_bootmem.patch > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>