On Fri, Jan 10, 2014 at 02:04:58PM -0500, Prarit Bhargava wrote:
> kdump uses memmap=exactmap and mem=X values
Minor nit. Kdump only uses memmap=exactmap and not mem=X. mem=X is there
for debugging. So lets fix the changelog.
[..]
> static int __init parse_memmap_opt(char *str)
> {
> + int ret;
> +
> while (str) {
> char *k = strchr(str, ',');
>
> if (k)
> *k++ = 0;
>
> - parse_memmap_one(str);
> + ret = parse_memmap_one(str);
> + if (!ret)
> + set_acpi_no_memhotplug();
We want to call this only in case of memmap=exactmap and not other memmap=
options. So I think instead of here, call it inside parse_memmap_one()
where exactmap check is done.
if (!strncmp(p, "exactmap", 8)) {
set_acpi_no_memhotplug();
}
Thanks
Vivek
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>