On 01/10/2014 01:10 PM, Johannes Weiner wrote: > Page cache radix tree slots are usually stabilized by the page lock, > but shmem's swap cookies have no such thing. Because the overall > truncation loop is lockless, the swap entry is currently confirmed by > a tree lookup and then deleted by another tree lookup under the same > tree lock region. > > Use radix_tree_delete_item() instead, which does the verification and > deletion with only one lookup. This also allows removing the > delete-only special case from shmem_radix_tree_replace(). > > Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx> > Reviewed-by: Minchan Kim <minchan@xxxxxxxxxx> Reviewed-by: Rik van Riel <riel@xxxxxxxxxx> -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>