On Fri, Jan 3, 2014 at 12:57 AM, Mel Gorman <mgorman@xxxxxxx> wrote: > On Thu, Jan 02, 2014 at 08:25:22PM +0900, SeongJae Park wrote: >> Using enum instead of number for migratetype everywhere would be better >> for reading and understanding. >> >> Signed-off-by: SeongJae Park <sj38.park@xxxxxxxxx> > > This implicitly makes assumptions about the value of MIGRATE_UNMOVABLE > and does not appear to actually fix or improve anything. > > -- > Mel Gorman > SUSE Labs I thought the implicit assumptions may be helpful for some kind of people's readability. But, anyway, I agree and respect your opinion now. Thanks and Regards. SeongJae Park -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>