On Thu 19-12-13 10:32:29, Vladimir Davydov wrote: > On 12/18/2013 09:06 PM, Michal Hocko wrote: > > On Wed 18-12-13 17:16:53, Vladimir Davydov wrote: > >> Plus, rename memcg_register_cache() to memcg_init_cache_params(), > >> because it actually does not register the cache anywhere, but simply > >> initialize kmem_cache::memcg_params. > > I've almost missed this is a memory leak fix. > > Yeah, the comment is poor, sorry about that. Will fix it. > > > I do not mind renaming and the name but wouldn't > > memcg_alloc_cache_params suit better? > > As you wish. I don't have a strong preference for memcg_init_cache_params. I really hate naming... but it seems that alloc is a better fit. _init_ would expect an already allocated object. Btw. memcg_free_cache_params is called only once which sounds suspicious. The regular destroy path should use it as well? [...] -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>