On 12/18/2013 05:16 PM, Vladimir Davydov wrote: > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct mem_cgroup *memcg, const char *name, size_t size, > get_online_cpus(); > mutex_lock(&slab_mutex); > > - if (!kmem_cache_sanity_check(memcg, name, size) == 0) > - goto out_locked; > + err = kmem_cache_sanity_check(memcg, name, size); > + if (err) > + goto out_unlock; > > /* > * Some allocators will constraint the set of valid flags to a subset Theoretically in future kmem_cache_sanity_check() can return positive value. Probably it's better to check (err < 0) in caller ? Thank you, Vasily Averin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>