On Fri, Dec 13, 2013 at 04:40:58PM +0000, Christoph Lameter wrote: > On Fri, 13 Dec 2013, Joonsoo Kim wrote: > > > Could you review this patch? > > I think that we should merge it to fix the problem reported by Christian. > > I'd be fine with clearing __GFP_NOFAIL but not with using the same flags > as for a higher order alloc. __GFP_NORETRY and __GFP_NOWARN should be left > untouched for the minimal alloc. Hello. So you don't want to add __GFP_NORETRY and __GFP_NOWARN for kmemcheck? I think that it isn't good idea, since users would meet *unexpected* allocation failure if they enable kmemcheck and slub uses different flags for kmemcheck. It makes users who want to debug their own problems embarrass. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>