Re: [PATCH v2 4/7] mm/migrate: remove putback_lru_pages, fix comment on putback_movable_pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >@@ -1704,6 +1688,12 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma,
> > 	nr_remaining = migrate_pages(&migratepages, alloc_misplaced_dst_page,
> > 				     node, MIGRATE_ASYNC, MR_NUMA_MISPLACED);
> > 	if (nr_remaining) {
> >+		if (!list_empty(&migratepages)) {
> >+			list_del(&page->lru);
> >+			dec_zone_page_state(page, NR_ISOLATED_ANON +
> >+					page_is_file_cache(page));
> >+			putback_lru_page(page);
> >+		}
> > 		putback_lru_pages(&migratepages);
> 
> You should remove this line. Otherwise,

Yes, you are right. I will send next version. T_T

> 
> Reviewed-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx>

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]